docs: workload name corrected as per the latest VS Installer#38500
Closed
MrJithil wants to merge 1 commit intonodejs:masterfrom
Closed
docs: workload name corrected as per the latest VS Installer#38500MrJithil wants to merge 1 commit intonodejs:masterfrom
MrJithil wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
build
targos
approved these changes
May 1, 2021
Member
Author
|
@targos I don't have the authorization to merge this pull request. Could you please help me to run the work flow? |
edsadr
approved these changes
May 1, 2021
aduh95
added
the
author ready
Trott
approved these changes
May 2, 2021
jasnell
approved these changes
May 3, 2021
Member
Author
|
@jasnell Could you please help me to merge this PR? I don't have merge permission. |
Member
|
@MrJithil ... the PR will be merged shortly. For most PRS there is a minimum 48 hour waiting time for reviews. We do have a fast-track option but there's only about an hour left before the 48 hours on this PR is up so it's better to just wait. |
Member
Author
|
@jasnell As we discussed yesterday, can we merge this pull request now? |
Member
|
Landed in 9df904b |
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
PR-URL: #38500 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38500 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows local machine setup guide suggests installing the prerequisites "Visual C++ build tools" workload from the visual studio build tool installer. But, there is not workload named "Visual C++ build tools" in the current installer. Instead, maybe the Microsoft team renamed that to just "C++ build tools" in the workload list.
Correcting the workload name as per the current installer list.
Reference: